eslint 8 support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visemet
requested changes
Feb 7, 2024
| rules: {"mongodb-server/resmoke-tags": ruleOptions}, | ||
| overrideConfig: { | ||
| env: { | ||
| "es6": true, |
There was a problem hiding this comment.
Let's change this line to "es2022": true match https://github.com/mongodb/mongo/blob/2cf2693a7846bb49b9e819c8be4863e096c85ebe/.eslintrc.yml#L2. Ditto line 15.
| @@ -23,7 +23,7 @@ | |||
| "dependencies": { | |||
| "commander": "2.16.0", | |||
| "diff": "3.5.0", | |||
| "eslint": "5.16.0", | |||
| "eslint": "8.28.0", | |||
There was a problem hiding this comment.
Let's also update the peerDependencies and engines.
One thought would be to use what is current in the ESLint generator.
"eslint": ">=7"
"node": "^14.17.0 || ^16.0.0 || >= 18.0.0"
Another thought would be to use what is declared in ESLint version 8.28.0.
"eslint": ">=8.28.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
I mostly care about ensuring node8 isn't supported because I think the trimStart() usage was always a problem for it and preventing the install would have been more obvious about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump eslint to 8.28, the version mongodb/mongo currently uses for linting.
modify resmoke-tags accordingly to be compatible with the new ESLint interface.
Update parser options to use the same ecmaversion and source type used for linting; this allows us to operate on files with import/export statements because we specify the source type as module.
We should maybe also change env.es6 to env.es2022 but I didn't get a chance to try this yet.
Confirmed this works for add-tags; didn't test anything else yet, but wanted to make this available in case anyone else needs to run the tool before I get back to this.